Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added <dc:issued> field to OPDS entries #715

Merged
merged 3 commits into from
Feb 23, 2022
Merged

Added <dc:issued> field to OPDS entries #715

merged 3 commits into from
Feb 23, 2022

Conversation

veloman-yunkan
Copy link
Collaborator

As agreed in #702 (comment)

As of this PR the <updated> field in OPDS entries is not affected in any way. The same data is simply duplicated in a <dc:issued> field. The <updated> field will be changed later, after 2 conditions are met:

  1. All respective client code is switched to use the <dc:issued> field
  2. library.xml format is enhanced to contain information about book metadata timestamps

@codecov
Copy link

codecov bot commented Feb 19, 2022 •
edited
Loading

Codecov Report

Merging #715 (f8da503) into master (5c38300) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head f8da503 differs from pull request most recent head ae2d7d2. Consider uploading reports for the commit ae2d7d2 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #715      +/-   ##
==========================================
+ Coverage   57.97%   57.99%   +0.02%     
==========================================
  Files          54       54              
  Lines        3569     3571       +2     
  Branches     2007     2009       +2     
==========================================
+ Hits         2069     2071       +2     
  Misses       1499     1499              
  Partials        1        1
Impacted Files Coverage Δ
src/book.cpp 86.66% <100.00%> (+0.18%) ⬆️
src/opds_dumper.cpp 99.07% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c38300...ae2d7d2. Read the comment docs.

@veloman-yunkan veloman-yunkan mentioned this pull request Feb 19, 2022
Open
@kelson42 kelson42 added this to the 10.1.0 milestone Feb 19, 2022
@mgautierfr
Copy link
Member

All respective client code is switched to use the dc:issued field

Most of the client use libkiwix to parse the OPDS stream. It would be nice to also update the OPDS parsing part in this pr also.
It seems that the only part to change is https://github.com/kiwix/libkiwix/blob/master/src/book.cpp#L164

@veloman-yunkan
Copy link
Collaborator Author

All respective client code is switched to use the dc:issued field

Most of the client use libkiwix to parse the OPDS stream. It would be nice to also update the OPDS parsing part in this pr also. It seems that the only part to change is https://github.com/kiwix/libkiwix/blob/master/src/book.cpp#L164

@mgautierfr Done

mgautierfr
mgautierfr reviewed Feb 22, 2022
View reviewed changes
src/book.cpp Outdated Show resolved Hide resolved
@mgautierfr
Copy link
Member

Agree. Please rebase-fixup before we merge.

@mgautierfr
Copy link
Member

Agree. Please rebase-fixup before we merge.

Done

@mgautierfr mgautierfr merged commit a11abcf into master Feb 23, 2022
@mgautierfr mgautierfr deleted the opds_dc_issued branch February 23, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgautierfr mgautierfr Awaiting requested review from mgautierfr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
10.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@veloman-yunkan @mgautierfr @kelson42